rdblue commented on code in PR #5436:
URL: https://github.com/apache/iceberg/pull/5436#discussion_r939693344
##########
python/pyiceberg/io/base.py:
##########
@@ -51,6 +51,14 @@ def tell(self) -> int:
def close(self) -> None:
...
+ @abstractmethod
+ def __enter__(self):
+ ...
+
+ @abstractmethod
+ def __exit__(self, exc_type, exc_val, exc_tb):
Review Comment:
Can we default this to `self.close()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]