rdblue commented on code in PR #5021:
URL: https://github.com/apache/iceberg/pull/5021#discussion_r939727576
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1176,6 +1198,19 @@ public Builder removeBranch(String branch) {
return this;
}
+ public Builder setStatistics(String snapshotId, @Nullable StatisticsFile
statisticsFile) {
+ Preconditions.checkNotNull(snapshotId, "snapshotId is null");
+ Preconditions.checkNotNull(statisticsFile, "statisticsFile is null");
+ this.statistics.put(snapshotId, statisticsFile);
+ return this;
Review Comment:
@findepi, the newer tests are going into `TestTableMetadata`. Before the
builder, `TableMetadata` exposed methods like `replaceSortOrder` that are
tested directly (that's why it's hard to find the tests). And quite a few
things are still tested end-to-end using the table operations themselves (like
`UpdateSchema`). I'd take a look at the tests for `replaceSortOrder` in
`TestTableMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
