amogh-jahagirdar commented on code in PR #5364:
URL: https://github.com/apache/iceberg/pull/5364#discussion_r940710889
##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -61,6 +61,19 @@ public TableScan appendsAfter(long fromSnapshotId) {
return appendsBetween(fromSnapshotId, currentSnapshot.snapshotId());
}
+ @Override
+ public TableScan useBranch(String name) {
Review Comment:
Yes good point. we should have a default implementation (well it's an
abstract class, so just an implementation) which throws Unsupported. Right now
DataTableScan would be the only table scan which supports branching and tagging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
