stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r941793316
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+
+Iceberg supports `UPSERT` based on the primary key when writing streaming data
into v2 table format. To enable it, create an `UPSERT` table or configuration
it when building a writer.
Review Comment:
it is probably confusing to call it `UPSERT table`. It seems to me that the
essence of this part is that there are two ways to enable upsert, which is
already covered the `Write options` section below.
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+
+Iceberg supports `UPSERT` based on the primary key when writing streaming data
into v2 table format. To enable it, create an `UPSERT` table or configuration
it when building a writer.
+
+For an `UPSERT` table, all writing will be in `UPSERT` mode unless you
overwrite it when building the writer:
+
+```
+CREATE TABLE `hive_catalog`.`default`.`sample` (
Review Comment:
If we want to be consistent with the other two sub sections `append` and
`overwrite` just before this, the example should be DataStream code snippet to
set the upsert write option. SQL is in a separate section somewhere above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
