rdblue commented on code in PR #5465:
URL: https://github.com/apache/iceberg/pull/5465#discussion_r941859631
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -78,7 +78,7 @@ def create_table(
location (str): Location for the table. Optional Argument.
partition_spec (PartitionSpec): PartitionSpec for the table.
sort_order (SortOrder): SortOrder for the table.
- properties (Properties | None): Table properties that can be a
string based dictionary. Optional Argument.
+ properties (Properties): Table properties that can be a string
based dictionary. Optional Argument.
Review Comment:
The text still says "Optional Argument"
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -208,14 +208,14 @@ def load_namespace_properties(self, namespace: str |
Identifier) -> Properties:
@abstractmethod
def update_namespace_properties(
- self, namespace: str | Identifier, removals: set[str] | None = None,
updates: Properties | None = None
+ self, namespace: str | Identifier, removals: set[str] | None = None,
updates: Properties = EMPTY_DICT
) -> PropertiesUpdateSummary:
"""Removes provided property keys and updates properties for a
namespace.
Args:
namespace (str | Identifier): Namespace identifier
removals (Set[str]): Set of property keys that need to be removed.
Optional Argument.
- updates (Properties | None): Properties to be updated for the
given namespace. Optional Argument.
+ updates (Properties): Properties to be updated for the given
namespace. Optional Argument.
Review Comment:
"Optional Argument"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
