rdblue commented on code in PR #5447:
URL: https://github.com/apache/iceberg/pull/5447#discussion_r942695004
##########
python/pyiceberg/catalog/hive.py:
##########
@@ -233,24 +299,47 @@ def create_table(
ValueError: If the identifier is invalid
"""
database_name, table_name =
self.identifier_to_database_and_table(identifier)
- current_time_millis = int(time.time())
+ seconds_since_epoch = int(time.time() * 1000)
+
+ location = self._resolve_table_location(location, database_name,
table_name)
+
+ metadata_location = f"{location}/metadata/{uuid.uuid4()}.metadata.json"
Review Comment:
In Java, we add a version to the start of the filename so that we can tell
the order. Can you do that here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
