rdblue commented on code in PR #5438:
URL: https://github.com/apache/iceberg/pull/5438#discussion_r942854426
##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -183,7 +183,6 @@ public static String toJson(Schema schema, boolean pretty) {
private static Type typeFromJson(JsonNode json) {
if (json.isTextual()) {
return Types.fromPrimitiveString(json.asText());
-
Review Comment:
Why remove it at all? Seems like an unncessary change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
