amogh-jahagirdar commented on PR #5379: URL: https://github.com/apache/iceberg/pull/5379#issuecomment-1211299573
> This change looks good to me. > > After a closer look, passing an explicit executor started to make more sense to me. I think we may add that overloaded method back once we consume these changes in other places. Right, this is my thought as well. Once we see there is a need for the API we can add that, it's harder to go the other way. Thanks for the review @aokolnychyi ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
