Fokko commented on code in PR #5490:
URL: https://github.com/apache/iceberg/pull/5490#discussion_r943220642
##########
python/tests/table/test_sorting.py:
##########
@@ -68,3 +70,12 @@ def test_sorting_schema():
),
)
]
+
+
+def test_sorting_to_string(sort_order: SortOrder):
+ expected = """[
+ identity(19) ASC NULLS_FIRST
Review Comment:
I took inspiration from the Java implementation, and it looks like there is
no comma:
https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/SortOrder.java#L137-L150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
