kbendick commented on code in PR #5495:
URL: https://github.com/apache/iceberg/pull/5495#discussion_r946270367
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##########
@@ -103,11 +102,14 @@ public class DeleteOrphanFilesSparkAction extends
BaseSparkAction<DeleteOrphanFi
implements DeleteOrphanFiles {
private static final Logger LOG =
LoggerFactory.getLogger(DeleteOrphanFilesSparkAction.class);
- private static final Splitter COMMA = Splitter.on(",");
private static final Map<String, String> EQUAL_SCHEMES_DEFAULT =
ImmutableMap.of("s3n,s3a", "s3");
Review Comment:
I was wondering this as well recently when looking at the format of equal
authorities.
For the common case of (s3a, s3n) -> (s3), s3 is still an expected value
correct?
I like the idea quite a lot and it's fairly clean, but for working with it
it seems like Map(s3 -> s3a,s3n,s3) or set of all values would be easier to use
programmatically.
But it's easy enough to map the values to what we need.
To clarify: (s3a,s3n) -> (s3) signifies that all 3 values should be used but
we should write out s3 whenever possible, correct?
Sorry I missed the discussion on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
