kbendick commented on code in PR #5530:
URL: https://github.com/apache/iceberg/pull/5530#discussion_r947057484
##########
aws/src/integration/java/org/apache/iceberg/aws/lakeformation/LakeFormationTestBase.java:
##########
@@ -384,7 +384,7 @@ private static void attachRolePolicyIfNotExists(String
policyArn, String policyN
iam.getRolePolicy(GetRolePolicyRequest.builder().roleName(roleName).policyName(policyName).build());
LOG.info("Policy {} already attached to role {}", policyName, roleName);
} catch (NoSuchEntityException e) {
- LOG.info("Attaching policy {} to role {} {}", policyName, roleName, e);
+ LOG.info("Attaching policy {} to role {}", policyName, roleName, e);
Review Comment:
👍
##########
build.gradle:
##########
@@ -27,7 +27,7 @@ buildscript {
}
dependencies {
classpath 'gradle.plugin.com.github.jengelman.gradle.plugins:shadow:7.0.0'
- classpath 'com.palantir.baseline:gradle-baseline-java:4.0.0'
+ classpath 'com.palantir.baseline:gradle-baseline-java:4.42.0'
Review Comment:
Nit / non-blocking: Should we separate the error prone changes from the
upgrade itself? Not a big deal to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
