Fokko commented on code in PR #5488: URL: https://github.com/apache/iceberg/pull/5488#discussion_r947194680
########## python/pyiceberg/catalog/__init__.py: ########## @@ -25,6 +26,41 @@ from pyiceberg.table.partitioning import UNPARTITIONED_PARTITION_SPEC, PartitionSpec from pyiceberg.table.sorting import UNSORTED_SORT_ORDER, SortOrder from pyiceberg.typedef import EMPTY_DICT, Identifier, Properties +from pyiceberg.utils.config import Config, merge_config + +logger = logging.getLogger(__name__) + +_env_config = Config() + + +def load_catalog(name: str, uri: str, **properties: str | None) -> Catalog: Review Comment: Of course, updated! Keep in mind that we determine the catalog based on the `uri`, so for dynamo you should set the URI to Dynamo. We could also pass the properties to a static method on the Catalog, which then returns a boolean if the properties match the catalog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
