kbendick commented on code in PR #5550:
URL: https://github.com/apache/iceberg/pull/5550#discussion_r947238730
##########
spark/v3.1/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:
##########
@@ -79,6 +79,7 @@ public abstract class WritersBenchmark extends
IcebergSourceBenchmark {
private PartitionSpec unpartitionedSpec;
private PartitionSpec partitionedSpec;
+ @Override
protected abstract FileFormat fileFormat();
Review Comment:
It is odd to declare an Override of an abstract method and keep it abstract.
This matches the same file in Spark 3.2 code, so I prefer this for
consistency reasons.
But I don’t have a strong preference. I could update this one and then leave
the other versions alone one or update all of them to remove it (since it’s in
the parent class).
##########
spark/v3.1/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:
##########
@@ -79,6 +79,7 @@ public abstract class WritersBenchmark extends
IcebergSourceBenchmark {
private PartitionSpec unpartitionedSpec;
private PartitionSpec partitionedSpec;
+ @Override
protected abstract FileFormat fileFormat();
Review Comment:
It _is_ definitely odd to declare an Override of an abstract method and keep
it abstract.
This matches the same file in Spark 3.2 code, so I prefer this for
consistency reasons.
But I don’t have a strong preference. I could update this one and then leave
the other versions alone one or update all of them to remove it (since it’s in
the parent class).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
