rdblue commented on code in PR #5539:
URL: https://github.com/apache/iceberg/pull/5539#discussion_r950384092
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -210,6 +232,11 @@ protected String tableName() {
return fullName;
}
+ @Override
+ protected EncryptionManagerFactory encryptionManagerFactory() {
Review Comment:
Why is this exposing the factory? Shouldn't this use the factory to return
an encryption manager
[here](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/TableOperations.java#L72)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
