amogh-jahagirdar commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r952688281
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -304,9 +304,12 @@ protected void validateAddedDataFiles(
* @param conflictDetectionFilter an expression used to find new conflicting
data files
*/
protected void validateAddedDataFiles(
- TableMetadata base, Long startingSnapshotId, Expression
conflictDetectionFilter) {
+ TableMetadata base,
+ Long startingSnapshotId,
+ Expression conflictDetectionFilter,
+ Snapshot snapshot) {
Review Comment:
Would it make sense to pass in just the snapshot id, and call it
endingSnapshotId? It also feels more readable to put the parameter next to
startingSnapshotId because it's like we're passing in a start and end in the
branch lineage.
For reference:
https://github.com/apache/iceberg/pull/5595/files#diff-f2d4265e007483f23a69703b88348743aecf99cc98395cd1730de3900a609eb6R339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
