wypoon commented on code in PR #5159:
URL: https://github.com/apache/iceberg/pull/5159#discussion_r953303333
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -177,20 +179,17 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
}
try {
- clients.run(
- client -> {
- client.dropTable(
- database,
- identifier.name(),
- false /* do not delete data */,
- false /* throw NoSuchObjectException if the table doesn't
exist */);
- return null;
- });
-
+ clients.run(client -> {
+ client.dropTable(database, identifier.name(),
+ false /* do not delete data */,
+ false /* throw NoSuchObjectException if the table doesn't exist
*/);
+ return null;
+ });
Review Comment:
This seems to be a purely formatting change. It is unnecessary.
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -345,4 +345,11 @@ private TableProperties() {}
public static final String UPSERT_ENABLED = "write.upsert.enabled";
public static final boolean UPSERT_ENABLED_DEFAULT = false;
+
+ /**
+ * Table properties to be used when dropping a table. Contains a list of
locations that are owned
+ * by the table and should also be dropped.
+ */
+ public static final String LOCATIONS_OWNED_BY_TABLE =
"locations-owned-by-table";
Review Comment:
How would this property be populated? Does the user have to specify this
explicitly per table? Or will a catalog auto-populate it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
