szehon-ho commented on code in PR #5426:
URL: https://github.com/apache/iceberg/pull/5426#discussion_r954345218
##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -92,4 +95,44 @@ public static Map<String, String> propertiesWithPrefix(
.filter(e -> e.getKey().startsWith(prefix))
.collect(Collectors.toMap(e -> e.getKey().replaceFirst(prefix, ""),
Map.Entry::getValue));
}
+
+ public static Map<String, String> applySchemaChanges(
+ Map<String, String> properties,
+ List<String> deletedColumns,
+ Map<String, String> renamedColumns,
+ Set<String> columnPrefixProperties) {
Review Comment:
Nit: what do you think to change to prefixProperties or columnProperties?
columnPrefixProperties may indicate wrongly that column is the prefix, so its a
bit misleading at first.
##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -92,4 +95,44 @@ public static Map<String, String> propertiesWithPrefix(
.filter(e -> e.getKey().startsWith(prefix))
.collect(Collectors.toMap(e -> e.getKey().replaceFirst(prefix, ""),
Map.Entry::getValue));
}
+
+ public static Map<String, String> applySchemaChanges(
+ Map<String, String> properties,
+ List<String> deletedColumns,
+ Map<String, String> renamedColumns,
+ Set<String> columnPrefixProperties) {
+ if (!properties.keySet().stream()
Review Comment:
Nit: coudl we keep noneMatch, like in original code? Its usually harder to
read negations in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
