kbendick commented on code in PR #5313:
URL: https://github.com/apache/iceberg/pull/5313#discussion_r955657126
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -177,6 +177,12 @@ private TableProperties() {}
public static final String AVRO_COMPRESSION_LEVEL_DEFAULT = null;
public static final String ORC_STRIPE_SIZE_BYTES =
"write.orc.stripe-size-bytes";
+
+ public static final String ORC_BLOOM_FILTER_COLUMNS =
"write.orc.bloom.filter.columns";
Review Comment:
Nit: Ideally there would be a default value,
`ORC_BLOOM_FILTER_COLUMNS_DEFAULT`. Even if it’s null (like Avro compression
level default) or empty string, I think it’s better for readability and safe
refactoring later to have the default defined where the rest are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
