Fokko commented on code in PR #5627:
URL: https://github.com/apache/iceberg/pull/5627#discussion_r958814479
##########
python/pyiceberg/schema.py:
##########
@@ -276,6 +279,32 @@ def primitive(self, primitive: PrimitiveType) -> T:
"""Visit a PrimitiveType"""
+class PreOrderSchemaVisitor(Generic[T], ABC):
Review Comment:
It is pre-order traversal since we start at the root and then move to the
leaves. In order is a bit less intuitive since it is not a binary tree. You
could also do a reverse in-order, but not sure if we need that. We can also
call it CustomOrder if you have a strong preference, but I think pre-order is
the most logical way of using this visitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
