bryanck commented on code in PR #5681:
URL: https://github.com/apache/iceberg/pull/5681#discussion_r959901315


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1011,8 +1011,10 @@ public <D> CloseableIterable<D> build() {
             conf.unset(property);
           }
           optionsBuilder = HadoopReadOptions.builder(conf);
+          optionsBuilder.withCodecFactory(new ParquetCodecFactory(conf, 0));
         } else {
           optionsBuilder = ParquetReadOptions.builder();
+          optionsBuilder.withCodecFactory(new ParquetCodecFactory(new 
Configuration(), 0));

Review Comment:
   The page size isn't used for decompressors according to [this 
comment](https://github.com/apache/parquet-mr/blob/6add62754b3d53e30376360f8d215da004fa8096/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/CodecFactory.java#L57).
 This is what is 
[currently](https://github.com/apache/parquet-mr/blob/6add62754b3d53e30376360f8d215da004fa8096/parquet-hadoop/src/main/java/org/apache/parquet/ParquetReadOptions.java#L174)
 being set by default in the options builder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to