findepi commented on code in PR #4741:
URL: https://github.com/apache/iceberg/pull/4741#discussion_r966771547
##########
core/src/main/java/org/apache/iceberg/GenericBlobMetadata.java:
##########
@@ -26,7 +27,17 @@
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-public class GenericBlobMetadata implements BlobMetadata {
+public class GenericBlobMetadata implements BlobMetadata, Serializable {
+
+ public static BlobMetadata from(org.apache.iceberg.puffin.BlobMetadata
puffinMetadata) {
Review Comment:
> we don't want to serialize (as in Serializable) the Puffin BlobMetadata
i see https://github.com/apache/iceberg/pull/4741#discussion_r966204993 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
