ajantha-bhat commented on code in PR #5754:
URL: https://github.com/apache/iceberg/pull/5754#discussion_r970466593
##########
spark/v3.3/build.gradle:
##########
@@ -193,8 +193,12 @@
project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio
dependencies {
api project(':iceberg-api')
- implementation
project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}")
- implementation
project(":iceberg-spark:iceberg-spark-extensions-${sparkMajorVersion}_${scalaVersion}")
+
implementation(project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}"))
{
+ exclude group: 'org.scala-lang', module: 'scala-library'
Review Comment:
sounds good to me as spark is providing the `scala.collection.compat` also.
<img width="992" alt="image"
src="https://user-images.githubusercontent.com/5889404/190136254-6b5aa236-09a8-481d-a00f-4c290a4baf08.png";>
Updated the PR. Manually verified that there is no scala folder with the
runtime jars. let's wait for the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/5889404/190136254-6b5aa236-09a8-481d-a00f-4c290a4baf08.png"](https://user-images.githubusercontent.com/5889404/190136254-6b5aa236-09a8-481d-a00f-4c290a4baf08.png"){kind=link}