amogh-jahagirdar commented on code in PR #5793:
URL: https://github.com/apache/iceberg/pull/5793#discussion_r974442122
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -125,13 +122,7 @@ static class ObjectStoreLocationProvider implements
LocationProvider {
private static String dataLocation(Map<String, String> properties, String
tableLocation) {
String dataLocation =
properties.get(TableProperties.WRITE_DATA_LOCATION);
if (dataLocation == null) {
- dataLocation = properties.get(TableProperties.OBJECT_STORE_PATH);
- if (dataLocation == null) {
- dataLocation =
properties.get(TableProperties.WRITE_FOLDER_STORAGE_LOCATION);
- if (dataLocation == null) {
- dataLocation = String.format("%s/data", tableLocation);
- }
- }
Review Comment:
I'm not sure about this. I understand we want to deprecate these properties,
but wouldn't this break compatibility in terms of the data location to write to
for existing tables which have these older properties set?
This may be intentional desire with an upgraded 1.0 Iceberg library and an
older table, but it forces users to have to update their table properties on
their tables to use 1.0 Iceberg library and have their existing behavior which
does not seem entirely right to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
