gaborkaszab commented on code in PR #5793:
URL: https://github.com/apache/iceberg/pull/5793#discussion_r974949892
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -125,13 +122,7 @@ static class ObjectStoreLocationProvider implements
LocationProvider {
private static String dataLocation(Map<String, String> properties, String
tableLocation) {
String dataLocation =
properties.get(TableProperties.WRITE_DATA_LOCATION);
if (dataLocation == null) {
- dataLocation = properties.get(TableProperties.OBJECT_STORE_PATH);
- if (dataLocation == null) {
- dataLocation =
properties.get(TableProperties.WRITE_FOLDER_STORAGE_LOCATION);
- if (dataLocation == null) {
- dataLocation = String.format("%s/data", tableLocation);
- }
- }
Review Comment:
@amogh-jahagirdar thanks for the feedback!
I had the same concern of dropping these properties that it does have an
effect on existing tables. I created this PR so that we can discuss. I wasn't
sure that a major release bump allows us to make such a big break in the API
and on existing tables.
I'm wondering if even a major version bump is not enough to drop these
properties then is there a point of annotating these properties as deprecated.
In case there isn't a scenario where we can drop them I think we can remove
that annotation. Should I go forward and do so?
Some of them are even said to be removed in 0.14 and are still around that I
find misleading.
Another idea would be that we leave them as they are now but setting it
should be prevented in 1.0.0 onwards. E.g. it won't be allowed to create a
table using those properties, and we could also reject setting these for
existing tables.
I'd appreciate to hear your opinion.
Tagging @flyrain as the author of the patch that introduced those
annotations:
https://github.com/apache/iceberg/commit/12e30ebaeb6dc0ff7e6bb01c0d9f8ae8a5f06ddf#diff-5620e28d3a7d13259b12e251b9eca2f59c66fd3ab96d6b62c36062f1f5ac0ca1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
