Fokko commented on code in PR #5772:
URL: https://github.com/apache/iceberg/pull/5772#discussion_r977494099
##########
data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java:
##########
@@ -287,10 +287,10 @@ public void testMaxColumnsWithDefaultOverride() throws
IOException {
OutputFileFactory.builderFor(maxColumnTable, 1,
1).format(fileFormat).build();
T row = toGenericRow(1, numColumns);
- DataWriter dataWriter =
+ DataWriter<T> dataWriter =
Review Comment:
Unrelated note: I'm a big fan of the try-with-resource pattern, instead of
calling the `.close()` (or forgetting to do so).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
