singhpk234 commented on code in PR #5888:
URL: https://github.com/apache/iceberg/pull/5888#discussion_r984319484
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -479,6 +480,49 @@ private void applyUpdates(TableOperations underlyingOps) {
// Cannot pass even with retry due to conflicting metadata changes.
So, break the
// retry-loop.
throw new PendingUpdateFailedException(e);
+
+ } catch (ValidationException e) {
+ if (PropertyUtil.propertyAsBoolean(
+ base.properties(),
+ TableProperties.ROLLBACK_COMPACTION_ON_CONFLICTS_ENABLED,
+
TableProperties.ROLLBACK_COMPACTION_ON_CONFLICTS_ENABLED_DEFAULT)) {
Review Comment:
> We are not just rolling back, but we are also reapplying the changes after
rolling back. Maybe something like REAPPLY_REPLACE_ON_CONFLICTS_ENABLED? Any
other suggestions for the name?
makes sense, how about something like
`RETRY_WITH_ROLLBACK_REPLACE_ON_CONFLICTS_ENABLED`, it gives an impression that
we are retrying the applying the changes with roll-backing replace operations
snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
