nastra commented on code in PR #5908:
URL: https://github.com/apache/iceberg/pull/5908#discussion_r988823794
##########
api/src/test/java/org/apache/iceberg/expressions/TestExpressionUtil.java:
##########
@@ -63,6 +66,23 @@ public void testSanitizeIn() {
ExpressionUtil.toSanitizedString(Expressions.in("test", 34, 345)));
}
+ @Test
+ public void testSanitizeLongIn() {
Review Comment:
I think it would be good to have a small test around the threshold value
`LONG_IN_PREDICATE_ABBREVIATION_THRESHOLD` to make sure values are
abbreviated/not abbreviated.
EDIT: I accidentally noticed that something like
`ExpressionUtil.toSanitizedString(Expressions.in("test", IntStream.range(0,
10).boxed().toArray()))` actually produces `test IN ((-2147483647-digit-int),
(1-digit-int), ... (8 values hidden, 10 in total) ...)`. Notice the
`-2147483647-digit-int` because of the `0`. FWIW, this isn't something that is
being caused by this PR, so I'll take a look into this separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
