rdblue commented on code in PR #5913:
URL: https://github.com/apache/iceberg/pull/5913#discussion_r989565092
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -147,15 +151,16 @@ void existing(ManifestEntry<F> entry) {
* <p>The entry's snapshot ID will be this manifest's snapshot ID.
*
* @param deletedFile a file
+ * @param dataSequenceNumber a data sequence number for the file
*/
- public void delete(F deletedFile) {
- addEntry(reused.wrapDelete(snapshotId, deletedFile));
+ public void delete(F deletedFile, long dataSequenceNumber) {
Review Comment:
Yeah, the other option is passing `null`, but that would effectively set the
data sequence number to `0` for the deleted file, which is not correct for
reconstructing when the data was added. Better to throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
