hendrikmakait commented on issue #5924: URL: https://github.com/apache/iceberg/issues/5924#issuecomment-1271153715
@rdblue: My main point is that this change affects debugging, which `__repr__` is intended for (https://docs.python.org/3/reference/datamodel.html#object.__repr__). This will make it more involved to figure out what exact object one is dealing with and to see whether code, e.g., conversions, worked as intended from just glancing at debugger output. For example, the conversion `LongLiteral(1234) -> FloatLiteral(1234.0)` will become a `literal(1234) -> literal(1234.0)`. While we are technically able to see that some conversion is happening, we have to spot the change in `.0` and we still don't know whether it's a `FloatLiteral` or `DoubleLiteral`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
