nastra commented on code in PR #5944:
URL: https://github.com/apache/iceberg/pull/5944#discussion_r990983232
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -111,7 +122,15 @@ public static boolean selectsPartitions(
private static class ExpressionSanitizer
extends ExpressionVisitors.ExpressionVisitor<Expression> {
- private static final ExpressionSanitizer INSTANCE = new
ExpressionSanitizer();
+ private final long now;
+ private final int today;
+
+ private ExpressionSanitizer() {
+ long nowMillis = System.currentTimeMillis();
+ OffsetDateTime nowDateTime =
Instant.ofEpochMilli(nowMillis).atOffset(ZoneOffset.UTC);
+ this.now = nowMillis * 1000;
Review Comment:
I think it would be good to name this `nowMicros` here and in the other
places to make it clearer that we're dealing with microseconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
