chenjunjiedada commented on code in PR #5913:
URL: https://github.com/apache/iceberg/pull/5913#discussion_r991754698
##########
core/src/main/java/org/apache/iceberg/GenericManifestEntry.java:
##########
@@ -44,14 +45,16 @@ private GenericManifestEntry(GenericManifestEntry<F>
toCopy, boolean fullCopy) {
this.schema = toCopy.schema;
this.status = toCopy.status;
this.snapshotId = toCopy.snapshotId;
+ this.dataSequenceNumber = toCopy.dataSequenceNumber;
this.sequenceNumber = toCopy.sequenceNumber;
this.file = toCopy.file().copy(fullCopy);
}
- ManifestEntry<F> wrapExisting(Long newSnapshotId, Long newSequenceNumber, F
newFile) {
+ ManifestEntry<F> wrapExisting(Long newSnapshotId, Long
newDataSequenceNumber, F newFile) {
Review Comment:
@aokolnychyi , What class do you plan to add `fileSequenceNumber`?
`DataFile` and `DeleteFile`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
