rdblue commented on code in PR #5957:
URL: https://github.com/apache/iceberg/pull/5957#discussion_r992778853
##########
python/pyiceberg/catalog/rest.py:
##########
@@ -225,15 +228,18 @@ def url(self, endpoint: str, prefixed: bool = True,
**kwargs) -> str:
return url + endpoint.format(**kwargs)
def _fetch_access_token(self, credential: str) -> str:
- client_id, client_secret = credential.split(":")
+ if SEMICOLON not in credential:
+ raise ValueError("Expected semicolon in the credential to separate
the client id and secret.")
Review Comment:
In Java, we just use the whole string as the client secret and set the
client ID to empty string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
