stevenzwu commented on code in PR #5922:
URL: https://github.com/apache/iceberg/pull/5922#discussion_r994055210
##########
api/src/main/java/org/apache/iceberg/Table.java:
##########
@@ -48,6 +48,17 @@ default String name() {
*/
TableScan newScan();
+ /**
+ * Create a new {@link BatchScan batch scan} for this table.
+ *
+ * <p>Once a batch scan is created, it can be refined to project columns and
filter data.
+ *
+ * @return a batch scan for this table
+ */
+ default BatchScan newBatchScan() {
Review Comment:
I am wondering if `batch` is the most accurate name. `batch` jobs can also
do `incremental` scan. To me, `streaming/batch` is more about execution mode.
This scan is contrasting to the `incremental` scans below. Incremental scan
is meant for the difference between two snapshots (start, end). This scan is
more like a `snapshot` scan. It scans the table using a specific snapshot (as
point of view to the table). Just to bootstrap some brainstorming. what about
`newSnapshotScan`?
##########
api/src/main/java/org/apache/iceberg/BatchScanAdapter.java:
##########
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import java.util.Collection;
+import java.util.concurrent.ExecutorService;
+import org.apache.iceberg.expressions.Expression;
+import org.apache.iceberg.io.CloseableIterable;
+
+class BatchScanAdapter implements BatchScan {
Review Comment:
maybe add the comment to the class Javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
