szehon-ho commented on code in PR #3457:
URL: https://github.com/apache/iceberg/pull/3457#discussion_r995221676
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -184,11 +186,16 @@ public Dataset<FileInfo> expireFiles() {
expireSnapshots.cleanExpiredFiles(false).commit();
- // fetch metadata after expiration
- Dataset<FileInfo> validFileDS = validFileDS(ops.refresh());
+ // fetch valid files after expiration
+ TableMetadata updatedMetadata = ops.refresh();
+ Dataset<FileInfo> validFileDS = fileDS(updatedMetadata);
+
+ // fetch files referenced by expired snapshots
+ Set<Long> removedSnapshotIds = findExpiredSnapshotIds(originalMetadata,
updatedMetadata);
Review Comment:
Just noticed this variable name doesnt match spark 3.2, will change it.
(Initially it was 'expiredSnapshotIds' but it hides the member variable name
and so I made last minute change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
