amogh-jahagirdar commented on code in PR #5981:
URL: https://github.com/apache/iceberg/pull/5981#discussion_r995269913
##########
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java:
##########
@@ -64,15 +65,8 @@ public void cleanFiles(TableMetadata beforeExpiration,
TableMetadata afterExpira
}
}
- Set<ManifestFile> candidateManifestFilesForDeletion =
readManifests(expiredSnapshots);
Set<ManifestFile> manifestFilesAfterExpiration =
readManifests(snapshotsAfterExpiration);
-
- Set<ManifestFile> manifestsToDelete = Sets.newHashSet();
- for (ManifestFile candidateManifestFile :
candidateManifestFilesForDeletion) {
- if (!manifestFilesAfterExpiration.contains(candidateManifestFile)) {
- manifestsToDelete.add(candidateManifestFile);
- }
- }
+ Set<ManifestFile> manifestsToDelete =
manifestFilesToDelete(manifestFilesAfterExpiration, expiredSnapshots);
Review Comment:
With the task based approach we should guarantee if there's a failure that
it gets thrown and doesn't proceed to the next step. I've made sure to throw in
case determining manifests fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
