hililiwei commented on PR #5982: URL: https://github.com/apache/iceberg/pull/5982#issuecomment-1280191676
> looks great, but I would rename the copy method from `builder` to `from` as I think this is clearer. > > @rdblue / @hililiwei I also created #5985 to have a slightly shorter alternative (171 vs 376 LOC) that doesn't require a custom builder. Thanks fro your review. #5985 Annotations is really more concise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
