amogh-jahagirdar commented on code in PR #5981:
URL: https://github.com/apache/iceberg/pull/5981#discussion_r996543787
##########
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java:
##########
@@ -64,18 +64,11 @@ public void cleanFiles(TableMetadata beforeExpiration,
TableMetadata afterExpira
}
}
- Set<ManifestFile> candidateManifestFilesForDeletion =
readManifests(expiredSnapshots);
- Set<ManifestFile> manifestFilesAfterExpiration =
readManifests(snapshotsAfterExpiration);
+ Set<ManifestFile> manifestsToDelete =
readManifests(snapshotsBeforeExpiration);
Review Comment:
Ooh great catch, it was expiredSnapshots in the initial implementation but I
think when refactoring the code I somehow changed it to
snapshotsBeforeExpiration. will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
