nastra commented on code in PR #6001:
URL: https://github.com/apache/iceberg/pull/6001#discussion_r997739244
##########
flink/v1.15/build.gradle:
##########
@@ -134,7 +133,9 @@
project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
}
dependencies {
- implementation project(":iceberg-flink:iceberg-flink-${flinkMajorVersion}")
+
implementation(project(":iceberg-flink:iceberg-flink-${flinkMajorVersion}")) {
+ exclude group: 'org.apache.flink'
Review Comment:
yes, because otherwise if the exlude is configured for the entire
`implementation` configuration, the `org.apache.flink:flink-metrics-dropwizard`
will never make it into the runtime jar (because it's excluded).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
