gaborkaszab commented on code in PR #5763:
URL: https://github.com/apache/iceberg/pull/5763#discussion_r998231170
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -247,12 +241,29 @@ public void testReplaceTxnBuilder() throws Exception {
}
}
+ @Test
+ public void testCreateTableWithOwner() throws Exception {
+ Schema schema = getTestSchema();
+ PartitionSpec spec = PartitionSpec.builderFor(schema).bucket("data",
16).build();
+ TableIdentifier tableIdent = TableIdentifier.of(DB_NAME, "tbl");
+ String location = temp.newFolder("tbl").toString();
+ String owner = "some_owner";
+ ImmutableMap<String, String> properties =
Review Comment:
> Does this also write the username to the HMS table property list? Is this
what we expect?
Good point! This was also added ad an HMS table property but I think it's
not needed. I changed the code to only set the owner of the table but not to
add the owner field as a table property to HMS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
