hililiwei commented on code in PR #5984:
URL: https://github.com/apache/iceberg/pull/5984#discussion_r1000056385
##########
core/src/main/java/org/apache/iceberg/BaseIncrementalScan.java:
##########
@@ -45,6 +66,24 @@ public ThisT fromSnapshotInclusive(long fromSnapshotId) {
return newRefinedScan(tableOps(), table(), schema(), newContext);
}
+ @Override
+ public ThisT fromSnapshotExclusive(long fromSnapshotId, String
referenceName) {
+ // for exclusive behavior, table().snapshot(fromSnapshotId) check can't be
applied
+ // as fromSnapshotId could be matched to a parent snapshot that is already
expired
+ SnapshotRef snapshotRef = table().refs().get(referenceName);
+ Preconditions.checkArgument(snapshotRef != null, "Cannot find ref %s",
referenceName);
+ Preconditions.checkArgument(snapshotRef.isBranch(), "Ref %s is not a
branch", referenceName);
Review Comment:
From my personal understanding, tag is just a snapshot point. It does not
have a linear snapshot history, which is necessary for incremental reading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
