szehon-ho commented on code in PR #6025:
URL: https://github.com/apache/iceberg/pull/6025#discussion_r1003844542
##########
docs/spark-procedures.md:
##########
@@ -421,12 +421,18 @@ Existing data files are added to the Iceberg table's
metadata and can be read us
To leave the original table intact while testing, use [`snapshot`](#snapshot)
to create new temporary table that shares source data files and schema.
+Migrate will create a backup table with name [`table__BACKUP__`]. If you feel
confident that the migration succeeded
Review Comment:
I'm not sure if this is too much implementation detail.
But if we keep it, let's be more concise.
```
By default, the original table is retained with the name table_BACKUP_.
```
##########
docs/spark-procedures.md:
##########
@@ -421,12 +421,18 @@ Existing data files are added to the Iceberg table's
metadata and can be read us
To leave the original table intact while testing, use [`snapshot`](#snapshot)
to create new temporary table that shares source data files and schema.
+Migrate will create a backup table with name [`table__BACKUP__`]. If you feel
confident that the migration succeeded
+feel free to drop the backup table. You can also explicitly pass
[`drop_backup => true`] to drop the backup table after
+migration finishes.
+
#### Usage
-| Argument Name | Required? | Type | Description |
-|---------------|-----------|------|-------------|
-| `table` | ✔️ | string | Name of the table to migrate |
-| `properties` | ️ | map<string, string> | Properties for the new Iceberg
table |
+| Argument Name | Required? | Type | Description
|
+|---------------|---------|------|--------------------------------------------------------------------------------------|
+| `table` | ✔️ | string | Name of the table to migrate
|
+| `properties` | ️ | map<string, string> | Properties for the new Iceberg
table |
+| `drop_backup` | | boolean | When true, the backup table is dropped after
succesful migration (defaults to false) |
Review Comment:
I feel the 'successful migration' is a bit too redundant, how about (to make
it more concise)
``` When true, the original table will not be retained as backup (defaults
to false) ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
