nastra commented on code in PR #6065:
URL: https://github.com/apache/iceberg/pull/6065#discussion_r1006440948
##########
api/src/test/java/org/apache/iceberg/expressions/TestAggregateBinding.java:
##########
@@ -18,44 +18,28 @@
*/
package org.apache.iceberg.expressions;
-import java.util.Arrays;
import java.util.List;
import org.apache.iceberg.exceptions.ValidationException;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
import org.apache.iceberg.types.Types;
import org.apache.iceberg.types.Types.StructType;
import org.assertj.core.api.Assertions;
import org.junit.Assert;
import org.junit.Test;
public class TestAggregateBinding {
- private static final List<Expression.Operation> AGGREGATES =
- Arrays.asList(Expression.Operation.COUNT, Expression.Operation.MAX,
Expression.Operation.MIN);
+ private static final List<UnboundAggregate> list =
Review Comment:
I noticed that in this entire file we're using `UnboundAggregate` without
specifying a generic type. I think it would be good to replace all
`UnboundAggregate` by `UnboundAggregate<String>`? Same for `BoundAggregate`,
which should probably be `BoundAggregate<String, String>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
