szehon-ho commented on code in PR #5376:
URL: https://github.com/apache/iceberg/pull/5376#discussion_r1013485645
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -142,9 +142,21 @@ public static Schema selectNot(Schema schema, Set<Integer>
fieldIds) {
}
public static Schema join(Schema left, Schema right) {
- List<Types.NestedField> joinedColumns = Lists.newArrayList();
- joinedColumns.addAll(left.columns());
Review Comment:
@chenjunjiedada Yea that was my original version, and changed after comment
of @aokolnychyi
https://github.com/apache/iceberg/pull/5376#discussion_r956441487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
