SinghAsDev commented on PR #6064: URL: https://github.com/apache/iceberg/pull/6064#issuecomment-1302806360
> This makes sense to me, should we add a test for this to go over both of the branches of the `if`? Thanks for the review @Fokko ! Since this is exactly what we do in `ApplyNameMapping` I was hoping we can avoid additional test. But, do let me know if you feel strongly about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
