stevenzwu commented on code in PR #6111:
URL: https://github.com/apache/iceberg/pull/6111#discussion_r1013583775
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -102,14 +102,18 @@ public FlinkCatalog(
String defaultDatabase,
Namespace baseNamespace,
CatalogLoader catalogLoader,
- boolean cacheEnabled) {
+ boolean cacheEnabled,
+ long cacheExpirationIntervalMs) {
super(catalogName, defaultDatabase);
this.catalogLoader = catalogLoader;
this.baseNamespace = baseNamespace;
this.cacheEnabled = cacheEnabled;
Catalog originalCatalog = catalogLoader.loadCatalog();
- icebergCatalog = cacheEnabled ? CachingCatalog.wrap(originalCatalog) :
originalCatalog;
+ icebergCatalog =
+ cacheEnabled
Review Comment:
this breaks the compatibility. I feel the benefit probably doesn't justify
the breakage. we should keep the boolean config and just support the additional
expire interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
