danielcweeks commented on code in PR #6045:
URL: https://github.com/apache/iceberg/pull/6045#discussion_r1014232442
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -360,5 +360,7 @@ private TableProperties() {}
public static final String UPSERT_ENABLED = "write.upsert.enabled";
public static final boolean UPSERT_ENABLED_DEFAULT = false;
- public static final String HMS_TABLE_OWNER = "hms_table_owner";
+ public static final String HMS_TABLE_OWNER = "hive.metastore.table.owner";
Review Comment:
@haizhou-zhao thanks for updating the property names, but now looking more
closely at how these are used, I don't think they should live in the class.
Two of the properties are database properties (not table properties) and
they are all hive specific. We're trying to keep the properties here isolated
to general properties for tables (I know there are a few spark ones, but they
should probably move as well).
I think it makes sense just to put these as properties in the HiveCatalog
class or create a HiveCatalogProperties to encapsulate these behaviors.
Other than that, this looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
