rdblue commented on code in PR #6128:
URL: https://github.com/apache/iceberg/pull/6128#discussion_r1014915923
##########
python/pyiceberg/expressions/literals.py:
##########
@@ -213,6 +217,26 @@ class LongLiteral(Literal[int]):
def __init__(self, value: int):
super().__init__(value, int)
+ def __add__(self, other: Any) -> LongLiteral:
Review Comment:
What about `increment` and `decrement` methods since we only need to add or
subtract 1?
I think I like the idea of implementing this on the literal. The main issue
that I have with this is that it modifies the value of the literal. I think
introducing mutability is going to cause problems because this will modify the
original expression when we project, which should not happen. (That may also be
why expressions are no longer immutable?)
I think this should just return a new literal rather than `self`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
