rdblue commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1015644370
##########
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##########
@@ -71,6 +78,57 @@ public static CloseableIterable<FileScanTask> splitFiles(
return CloseableIterable.combine(splitTasks, tasks);
}
+ public static <T extends FileScanTask> Iterable<CombinedScanTask> planTasks(
Review Comment:
Oh, I see. PartitionScanTask is just a single file so we can use a partition
spec. I think that's good. We may want an interface that covers both the
PartitionScanTask and the combined version that exposes a struct type and tuple
of partition values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]