rdblue commented on code in PR #6140:
URL: https://github.com/apache/iceberg/pull/6140#discussion_r1015876595
##########
python/tests/expressions/test_visitors.py:
##########
@@ -874,36 +881,19 @@ def test_manifest_evaluator_less_than_overlap():
upper_bound=_to_byte_buffer(StringType(), "b"),
)
)
+ assert not _ManifestEvalVisitor(string_schema, expr).eval(manifest)
- assert not _create_manifest_evaluator(expr).eval(manifest)
-
-
-def test_manifest_evaluator_less_than_all_null():
- expr = BoundLessThan(
- term=BoundReference(
- field=NestedField(field_id=1, name="foo", field_type=StringType(),
required=False),
- accessor=Accessor(position=0, inner=None),
- ),
- literal=StringLiteral("a"),
- )
+def test_manifest_evaluator_less_than_all_null(string_schema: Schema):
+ expr = LessThan[str](Reference("col_str"), StringLiteral("a"))
manifest = _to_manifest_file(
PartitionFieldSummary(contains_null=False, contains_nan=False,
lower_bound=None, upper_bound=None)
Review Comment:
This doesn't look right. If all values are null then `contains_null` should
be `True`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
