foarsitter commented on code in PR #6158:
URL: https://github.com/apache/iceberg/pull/6158#discussion_r1017838716
##########
.github/workflows/python-ci.yml:
##########
@@ -43,9 +43,14 @@ jobs:
steps:
- uses: actions/checkout@v3
+ - name: Install poetry
+ run: pip install poetry
Review Comment:
I'm not a fan of pinning development requirements unless you have
information it will break anyway. This way the CI will learn us when Poetry
isn't backwards compatible anymore.
Remember to pin Poetry in the Makefile if decide to stick to a certain
Poetry verison
https://github.com/apache/iceberg/blob/abcc65b4f2e25dc9830cf0def907540fe15f5f76/python/Makefile#L19
also.
##########
.github/workflows/python-ci.yml:
##########
@@ -43,9 +43,14 @@ jobs:
steps:
- uses: actions/checkout@v3
+ - name: Install poetry
+ run: pip install poetry
Review Comment:
I'm not a fan of pinning development requirements unless you have
information it will break anyway. This way the CI will learn us when Poetry
isn't backwards compatible anymore.
Remember to pin Poetry in the Makefile if decide to stick to a certain
Poetry verison
https://github.com/apache/iceberg/blob/abcc65b4f2e25dc9830cf0def907540fe15f5f76/python/Makefile#L19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
